Add Testcontainers at development time integration test

spring-projects / spring-boot

Spring Boot

https://spring.io/projects/spring-boot

Apache License 2.0

73.89k stars 40.38k forks source link

Add Testcontainers at development time integration test #38045

Open philwebb opened 9 months ago

philwebb commented 9 months ago

Ideally we should have a test that catches issues like #37989

Wzy19930507 commented 9 months ago

Hi, @philwebb may i join this task?

philwebb commented 9 months ago

I'm sorry @Wzy19930507 but I don't have time to actually look into this one right now. Feel free to have a go at fixing it if you like, but I won't be able to provide much guidance at the moment.

Wzy19930507 commented 9 months ago

Hi, @philwebb Because of server need start before client get server metadata(such as ip/port), i need prove that call Container.start before create client bean.

Case to be verified that create client bean after BeanPostProcessor

LoadTimeWeaverAware
@Configuration
ApplicationRunner

But is this feasible?

eddumelendez commented 3 weeks ago

@philwebb I think this issue can be closed due to has been properly tested in #37989, right?

philwebb commented 6 days ago

I think we ended up manually testing the fix for #37989, I'd like to see if we can an actual integration test that fails the build if we accidentally reintroduce the problem.