search

spring-projects / spring-boot

Spring Boot
https://spring.io/projects/spring-boot
Apache License 2.0
73.62k stars 40.32k forks source link

GitHub actions is masking 'ci' #40042

Open philwebb opened 3 months ago

philwebb commented 3 months ago 
 > Task :spring-boot-project:spring-boot-devtools:checkArchitectureTest
> Task :spring-boot-project:spring-boot-devtools:checkCompileClasspathForProhibitedDependen***es
> Task :spring-boot-project:spring-boot-devtools:checkIntTestCompileClasspathForProhibitedDependen***es
> Task :spring-boot-project:spring-boot-devtools:checkIntTestRuntimeClasspathForProhibitedDependen***es
> Task :spring-boot-project:spring-boot-devtools:checkRuntimeClasspathForProhibitedDependen***es
> Task :spring-boot-project:spring-boot-devtools:checkSpringConfigurationMetadata
> Task :spring-boot-project:spring-boot-devtools:checkTestCompileClasspathForProhibitedDependen***es
> Task :spring-boot-project:spring-boot-devtools:checkTestRuntimeClasspathForProhibitedDependen***es
wilkinsona commented 3 months ago

We have an environment variable named CI. AIUI, GitHub Actions should only mask secret values and not plain environment variables but it appears that's not the case. https://github.com/spring-io/gradle-enterprise-conventions/issues/72 should remove the need for the environment variable but we need a release of the conventions first.

wilkinsona commented 1 month ago

Our CI environment variable is gone (it was set in the yaml config) but I've since learned that GitHub Actions sets the same environment variable automatically. I don't think there's anything we can do here, unfortunately.