Open MahatmaFatalError opened 3 days ago
snicoll
commented
3 days ago This section of the doc is auto-generated from the configuration properties metadata and there is no way to link one property with another. The best we could do is change the case of "acceptCount" to be "accept-count" to reduce the confusion.
wilkinsona
commented
3 days ago Thanks for the suggestion. I'm not sure that we can cross-link due to the way that the documentation is generated. However, we may be able to improve things by, for example, using the full property name or using accept-count rather than acceptCount.
We have a few places where we reference other properties. If we decide to change the description of max-connections, the others should probably be changed too. They are:
wilkinsona
commented
1 day ago There are more places where we reference other properties that my previous search didn't find. For example, we have several where we use the fully-qualified name of the property when referencing it. The following are some of these:
This docu page https://docs.spring.io/spring-boot/appendix/application-properties/index.html#application-properties.server.server.tomcat.max-connections states: "Maximum number of connections that the server accepts and processes at any given time. Once the limit has been reached, the operating system may still accept connections based on the "acceptCount" property."
But if you search for "acceptCount" you will find nothing. I assume https://docs.spring.io/spring-boot/appendix/application-properties/index.html#application-properties.server.server.tomcat.accept-count
server.tomcat.accept-countis meant with it. so I wanted to add a proper link to this property, however, it looks the adoc https://github.com/spring-projects/spring-boot/blob/v3.3.4/spring-boot-project/spring-boot-docs/src/docs/antora/modules/appendix/pages/application-properties/index.adoc is broken, at least I cannot find the sources where those properties are documented.