Closed mipo256 closed 1 year ago
@mp911de So I will just break this PR into 3 different PRs:
Am I correct?
1 + 2 are sufficient. Feel free to have another commit with polishing in one of the two pull requests. If you like, you can reuse this PR for the bugfix and create a new one for the newly introduced method. This change would require rebase and force-pushing which is fine for now.
@mp911de I have removed new method from this PR. Also I have introduced 2 commits - one with polishing, another with actual bugfix. Can you please re-review?
P.S: I will introduce new method once this changes will occur in the main branch
Mark @mp911de, when you will be able to rereview this PR?) I have already created a separate brunch for new overloaded method, but I am waiting for these changes to occur in main brunch to create new PR as we discussed
Thank you for your contribution. That's merged, polished, and backported now.
Implements #359 @mp911de, can you please check?)