search

spring-projects / spring-data-cassandra

Provides support to increase developer productivity in Java when using Apache Cassandra. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
https://spring.io/projects/spring-data-cassandra/
Apache License 2.0
374 stars 310 forks source link

DATACASS-188 - now able to supply options to table via cassandra admin otemplate #1385

Closed mipo256 closed 1 year ago

mipo256 commented 1 year ago

Implements #359 @mp911de, can you please check?)

mipo256 commented 1 year ago

@mp911de So I will just break this PR into 3 different PRs:

  1. Actual bugfix
  2. Creation of new overloaded method
  3. Polishing/refactoring

Am I correct?

mp911de commented 1 year ago

1 + 2 are sufficient. Feel free to have another commit with polishing in one of the two pull requests. If you like, you can reuse this PR for the bugfix and create a new one for the newly introduced method. This change would require rebase and force-pushing which is fine for now.

mipo256 commented 1 year ago

@mp911de I have removed new method from this PR. Also I have introduced 2 commits - one with polishing, another with actual bugfix. Can you please re-review?

P.S: I will introduce new method once this changes will occur in the main branch

mipo256 commented 1 year ago

Mark @mp911de, when you will be able to rereview this PR?) I have already created a separate brunch for new overloaded method, but I am waiting for these changes to occur in main brunch to create new PR as we discussed

mp911de commented 1 year ago

Thank you for your contribution. That's merged, polished, and backported now.