Refactor Cassandra query execution and mapping to consolidate mapping [DATACASS-280]

[spring-projects-issues]

Mark Paluch opened DATACASS-280 and commented

AbstractCassandraQuery and CassandraTemplate perform both conversions when executing queries. Some return types cannot be obtained from the CassandraTemplate in a generic way but must be retrieved by calling lower level methods such as queryForObject.

AbstractCassandraQuery utilizes complex conditionals to execute queries and so wrapping results in wrapper types (Optional, Future, Stream) is quite complex to achieve.

Changes:

• Pull mapping from AbstractCassandraQuery into AbstractCassandraConverter
• Refactor conditional execution to CassandraQueryExecution pattern
• Follow CassandraConverters and CustomConversions pattern such as in other Spring Data Modules
• Introduce DtoInstantiatingConverter
• Refactor ResultSet converters to Row converters

---

Issue Links:

• DATACASS-255 Initial test-cleanup ("depends on")

• DATACASS-128 Improve mapping specifications between Cassandra & Java

• DATACASS-247 Optional return type for Repositories returns Optional of resultset instead of Optional of Objectype ("supersedes")

• DATACASS-295 Add an easy way to configure auto json/xml serialization to cassandra text types ("supersedes")

Referenced from: pull request https://github.com/spring-projects/spring-data-cassandra/pull/53, and commits https://github.com/spring-projects/spring-data-cassandra/commit/183c502f7ea89739fe585ab401165b59ca61db33, https://github.com/spring-projects/spring-data-cassandra/commit/4772c5b6289e63fbc050e5a04eeaf6081ba66f98

[spring-projects-issues]

Mark Paluch commented

-Renamed and reorganized test structure should be applied on top of the PR for this ticket. Code is located on branch DATACASS-280-rename-move-all-tests-

[spring-projects-issues]

John Blum commented

Code review complete!