spring-projects / spring-data-couchbase

Provides support to increase developer productivity in Java when using Couchbase. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
https://spring.io/projects/spring-data-couchbase
Apache License 2.0
274 stars 191 forks source link

CouchbaseRepositoryQueryIntegrationTests.testExpiration broken after fixing ThreadLocal storage with save() #1839

Open mikereiche opened 11 months ago

mikereiche commented 11 months ago

CouchbaseRepositoryQueryIntegrationTests.testExpiration:759 expected: not equal but was: <0>a

It's because Options are now discarded on save()

    public void testExpiration() {
        Airport airport = new Airport("1", "iata21", "icao21");
        airportRepository.withOptions(InsertOptions.insertOptions().expiry(Duration.ofSeconds(10))).save(airport);
        Airport foundAirport = airportRepository.findByIata(airport.getIata());
        assertNotEquals(0, foundAirport.getExpiration());
        airportRepository.delete(airport);
    }
mikereiche commented 11 months ago

use template.withOptions(...).insertById(...).one(airport) instead.