search

spring-projects / spring-data-elasticsearch

Provide support to increase developer productivity in Java when using Elasticsearch. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
https://spring.io/projects/spring-data-elasticsearch/
Apache License 2.0
2.9k stars 1.33k forks source link

fix: upgrade version to 8.15.0 #2964

Closed JunHyungJang closed 2 weeks ago

JunHyungJang commented 1 month ago

This is my first contribute to spring-data-elasticsearch

I upgrade the version from 8.14.3 -> 8.15.0 as the issue mentioned

sothawo commented 1 month ago

Thanks for the contribution, but updating breaks the org.springframework.data.elasticsearch.client.elc.RequestConverter.reindex(ReindexRequest reindexRequest, boolean waitForCompletion) method, as the InlineScript that is used in this method isn't available anymore in 8.15.0. This can be either a bug in the Elasticsearch client (didn't have time to read the release notes), or we must see how to implement this functionality in a different way.

But the code doesn't even compile after the dependency update

JunHyungJang commented 1 month ago

@sothawo Thanks for the comment I will figure out how to fix it and able to compile

sothawo commented 2 weeks ago

Sorry for stepping in and taking this over in my own PR. I had a look at this and found that there were breaking changes in the Elasticsearch API in the script API and in the range API. But there was also a necessary adjustment in the reactive client code that was pretty ugly to find.