``DeleteQuery > refresh`` field is unused

spring-projects / spring-data-elasticsearch

Provide support to increase developer productivity in Java when using Elasticsearch. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.

https://spring.io/projects/spring-data-elasticsearch/

Apache License 2.0

2.9k stars 1.33k forks source link

``DeleteQuery > refresh`` field is unused #2973

Closed tuguri8 closed 1 week ago

tuguri8 commented 2 weeks ago

Hello,

I saw that refresh field on DeleteQuery is unused.

It seems to work differently than described in the javadoc (setting refresh=true doesn't seem to trigger refresh)

I think we should set the refresh based on the DeleteQuery > refresh field in documentDeleteByQueryRequest method, I'll open PR if you agree!

sothawo commented 2 weeks ago

fell free to implement this