Migrating jpa and web examples to junit 5.

spring-projects / spring-data-examples

Spring Data Example Projects

Apache License 2.0

5.2k stars 3.4k forks source link

Migrating jpa and web examples to junit 5. #602

Closed divyajnu08 closed 3 years ago

divyajnu08 commented 3 years ago

[x] You have read the Spring Data contribution guidelines.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

schauder commented 3 years ago

This relates to #583.

schauder commented 3 years ago

Thanks. That's polished and merged.

There were some unnecessary changes to the imports which I undid. You might want to check your formatter settings.

divyajnu08 commented 3 years ago

Thanks Jens !! I will take care in future.

On Fri, Jan 29, 2021 at 3:30 PM Jens Schauder notifications@github.com wrote:

Thanks. That's polished and merged.

There were some unnecessary changes to the imports which I undid. You might want to check your formatter settings.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-data-examples/pull/602#issuecomment-769705747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIS5ZA4ZXF6LLHZ25F3FZOTS4KBMHANCNFSM4WT3A2PA .

mp911de commented 3 years ago

On a related note, please make sure that the email address used in your commits either matches your GitHub profile or add the mail address to your GitHub profile. That way the commits will link back to your profile and you'll see these commits in your GitHub contribution graph.

divyajnu08 commented 3 years ago

On a related note, please make sure that the email address used in your commits either matches your GitHub profile or add the mail address to your GitHub profile. That way the commits will link back to your profile and you'll see these commits in your GitHub contribution graph.

ok sure