search

spring-projects / spring-data-geode

Spring Data support for Apache Geode
Apache License 2.0
51 stars 39 forks source link

Implement mustGroupTransactionEvents in GatewaySenderWrapper [DATAGEODE-344] #396

Open spring-projects-issues opened 4 years ago

spring-projects-issues commented 4 years ago

boglesby opened DATAGEODE-344 and commented

SpringCompatibilityTest CI build 16 failed with a compilation error.

GEODE-7971 introduced a new GatewaySender, mustGroupTransactionEvents() API, so GatewaySenderWrapper compilation failed because it does not implement this method.

[INFO] --- maven-compiler-plugin:3.8.1:compile (java-compile) @ spring-data-geode ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 485 source files to /home/geode/spring-data-geode/spring-data-geode/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/geode/spring-data-geode/spring-data-geode/src/main/java/org/springframework/data/gemfire/wan/GatewaySenderWrapper.java:[34,7] error: GatewaySenderWrapper is not abstract and does not override abstract method mustGroupTransactionEvents() in GatewaySender
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Spring Data for Apache Geode and Pivotal GemFire 2.4.0-NEXT-SNAPSHOT SUCCESS [ 41.308 s]
[INFO] Spring Data for Apache Geode ....................... FAILURE [ 49.658 s]
[INFO] Spring Data for Pivotal GemFire .................... SKIPPED
[INFO] Distribution for Spring Data Geode and Spring Data GemFire 2.4.0-NEXT-SNAPSHOT SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:33 min
[INFO] Finished at: 2020-05-26T19:08:10Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (java-compile) on project spring-data-geode: Compilation failure
[ERROR] /home/geode/spring-data-geode/spring-data-geode/src/main/java/org/springframework/data/gemfire/wan/GatewaySenderWrapper.java:[34,7] error: GatewaySenderWrapper is not abstract and does not override abstract method mustGroupTransactionEvents() in GatewaySender
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :spring-data-geode

No further details from DATAGEODE-344

spring-projects-issues commented 4 years ago

John Blum commented

First, this is not a bug since it is not affecting any production system/application. It is simply a version compatibility/upgrade/adaption problem.

Second, we cannot upgrade SDG to Apache Geode 1.14 since 1.13 is not even available yet.

SDG master is currently based on Apache Geode 1.12 awaiting for the arrival of Apache Geode 1.13. master is never based on anything other than GA bits for 3rd party dependencies.

SDG master-next ideally is never based on anything other than 1 snapshot version ahead of master, or the next Apache Geode version (i.e. 1.13) after the latest GA version (i.e. 1.12) that we anticipate picking up in our next release.

I see that GEODE-7971 is not targeted until Geode 1.14. As such, there is very little we can do about this at the moment