search

spring-projects / spring-data-jpa

Simplifies the development of creating a JPA-based data access layer.
https://spring.io/projects/spring-data-jpa/
Apache License 2.0
2.98k stars 1.41k forks source link

Ignore offset for `Limit` based query #3454

Closed quaff closed 3 months ago

quaff commented 5 months ago

Avoid calling Query.setFirstResult(0) which maybe generated sql contains unwanted offset 0.

Fix GH-3242

quaff commented 5 months ago

It's not likely that Hibernate will merge proposed PR linked to https://hibernate.atlassian.net/browse/HHH-17475, I think it's better to adapt at Spring Data JPA side.

mp911de commented 3 months ago

Thank you for your contribution. That's merged, polished, and backported now.