add: equals method to aggregation and aggregation ops

spring-projects / spring-data-mongodb

Provides support to increase developer productivity in Java when using MongoDB. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.

https://spring.io/projects/spring-data-mongodb/

Apache License 2.0

1.61k stars 1.08k forks source link

add: equals method to aggregation and aggregation ops #4693

Open therealansh opened 5 months ago

therealansh commented 5 months ago

Closes #4692 , Sorry for being the impatient one 😬 but would love to contribute.

[x] Aggregation
[x] AggregationPipeline
[ ] AggregationOperations:
- [x] AddFieldsOperation
- [x] BasicAggregation
- [x] BucketAutoOperation

[x] You have read the Spring Data contribution guidelines.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

pivotal-cla commented 5 months ago

@therealansh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 5 months ago

@therealansh Thank you for signing the Contributor License Agreement!

mp911de commented 5 months ago

Sorry for being the impatient one 😬 but would love to contribute.

Thanks a lot for your contribution, we're happy to welcome contributions, also from impatient ones 🤩

While at it, we have a couple more AggregationOperations. Care to extend the pull request by adding equals/hashCode methods to the remaining types as well? That would greatly improve the duration until we can merge your pull request.

therealansh commented 5 months ago

@mp911de was on it already, thats why added a checklist to the PR summary, will extend this PR to cover those as well thanks 🙌🏽