spring-projects / spring-data-mongodb

Provides support to increase developer productivity in Java when using MongoDB. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
https://spring.io/projects/spring-data-mongodb/
Apache License 2.0
1.59k stars 1.07k forks source link

Support derived queries using the same field multiple times #4715

Open hadjiski opened 1 month ago

hadjiski commented 1 month ago

Hi,

I am using a sparse index on the field fieldFoo and to best utilize it, I need to add an extra $exists condition before the $eqone. When I manually create it via a criteria, the object is fine and working:

Document{{fieldFoo=Document{{$exists=true, $eq='123'}}}}

Now trying to achieve it via a repository method:

getByFieldFooExistsAndFieldFoo(String value); // not working - it expects a true/false for the exists part

or

getByFieldFooExistsIsTrueAndFieldFoo(String value); // also not working due to syntax

this workaround syntax appears fine:

getByFieldFooExistsAndFieldFoo(boolean exists, String value); // passing always true

but the current spring-data source code is not supporting it:

org.springframework.data.mongodb.InvalidMongoDbApiUsageException: 
Due to limitations of the org.bson.Document, you can't add a second 'fieldFoo' 
expression specified as 'fieldFoo : 123'; 
Criteria already contains 'fieldFoo : Document{{$exists=true}}'

It appears to be a combination of the MongoQueryCreator and the AbstractQueryCreator, where combinations are not supported. Instead of simple a and chain of single conditions:

...
criteria.and("fieldFoo").exists(true)
criteria.and("fieldFoo").is("123")
...

we would need a capability of multi-conditions: ... criteria.and("fieldFoo").exists(true).is("123") ...

Was this not added on purpose, or just not perceived as widely used/needed?

mp911de commented 4 weeks ago

We do not support the implicit $and form using our Criteria API, however, we should explore how to enable querying the same field multiple times through our query derivation mechanism.

In the meantime, please use String-based @Query where you supply the desired query string yourself.