Superfluous `Arrays.fill(…)` in `ArrayUtils.getArrayClass(…)`

spring-projects / spring-data-r2dbc

Provide support to increase developer productivity in Java when using Reactive Relational Database Connectivity. Uses familiar Spring concepts such as a DatabaseClient for core API usage and lightweight repository style data access.

Apache License 2.0

708 stars 132 forks source link

Superfluous `Arrays.fill(…)` in `ArrayUtils.getArrayClass(…)` #813

Closed mitu2 closed 1 year ago

mitu2 commented 1 year ago

https://github.com/spring-projects/spring-data-r2dbc/blob/c3301f500c514682f37c473a6c9648add53dd8f5/src/main/java/org/springframework/data/r2dbc/support/ArrayUtils.java#L77 What is the purpose of using this? Isn't the default value of int [] 0? Why fill 0 once

mp911de commented 1 year ago

Good catch, seems like an oversight on our side.