spring-projects / spring-data-relational

Spring Data Relational. Home of Spring Data JDBC and Spring Data R2DBC.
https://spring.io/projects/spring-data-jdbc
Apache License 2.0
758 stars 345 forks source link

Unify integration test infrastructure #1181

Open schauder opened 2 years ago

schauder commented 2 years ago

Spring Data JDBC & R2DBC currently use different ways to implement integration tests.

JDBC

R2DBC

We should unify the test infrastructure and extract it into a test module which can be used by both modules.

Xiphoseer commented 1 month ago

The practical effect of this issue is that https://github.com/spring-projects/spring-data-relational?tab=readme-ov-file#building-from-source is inaccurate/broken because, without other setup, ./mvnw clean install will fail once it gets to failsafe:integration-test plugin invocation in the default-test phase of spring-data-r2dbc.

Which for me means, that I'd like to test some changes to potentially contribute but can't really make sure it doesn't break some r2dbc unit test.

schauder commented 1 month ago

@Xiphoseer I don't really see, how the described behaviour from you comment is caused by the different ways of handling integration tests for jdbc and r2dbc.

What failure are you seeing exactly? Is it complaining about a missing Docker environment? Or something else? You might consider creating a separate issue for this.