search

spring-projects / spring-data-relational

Spring Data Relational. Home of Spring Data JDBC and Spring Data R2DBC.
https://spring.io/projects/spring-data-jdbc
Apache License 2.0
764 stars 344 forks source link

Add NOT_IN judgment to QueryMapper's convertValue function #1745

Closed yande2011 closed 6 months ago

yande2011 commented 7 months ago

Closes #1744

mp911de commented 7 months ago

Care to add a few tests?

yande2011 commented 7 months ago

Care to add a few tests?

i add an CollectionToStringConverter convert on QueryMapper, shouldMapIsNotIn cant pass on oldVersion, passed on current

mp911de commented 7 months ago

Actually, having a test case that covers the newly introduced notIn functionality is what I was asking for.

yande2011 commented 7 months ago

Actually, having a test case that covers the newly introduced notIn functionality is what I was asking for.

Added test cases, NotIn can also work normally with CollectionToString converter, you can review it again

hosmanoglu commented 7 months ago

hi guys when could you merge this pr?

schauder commented 6 months ago

@yande2011 please provide a transcription of your name using latin characters to be used in @author tags?

yande2011 commented 6 months ago

@yande2011 please provide a transcription of your name using latin characters to be used in @author tags?

YAN Qiang

schauder commented 6 months ago

This is polished and merged.