search

spring-projects / spring-data-relational

Spring Data Relational. Home of Spring Data JDBC and Spring Data R2DBC.
https://spring.io/projects/spring-data-jdbc
Apache License 2.0
753 stars 345 forks source link

JDBC and R2DBC Criteria API documentation mismatch #1841

Closed mipo256 closed 3 weeks ago

mipo256 commented 1 month ago

Both JDBC and R2DBC modules support dynamic Criteria API, either via JdbcAggregateTemplate or R2dbcEntitytTemplate. It seems rather strange that we mention this in the R2DBC doc, but the exact same section in JDBC doc does not contain any Criteria API mentioning whatsoever. I'm not talking about fluent API as such, but rather about Criteria API usage.

I think we should incorporate a link to Criteria API doc section in R2DBC for Spring Data JDBC documentation, to avoid duplication.

schauder commented 1 month ago

Thanks for pointing out this gap in our documentation. I don't think that copying the section about the Criteria API is sufficient. Instead we should introduce a section about the querying capabilities based on Query in the JdbcAggregateTemplate