spring-projects-issues
commented
11 years ago Hendy Irawan commented
Is there any way this relates to our implementation of RequestAttributes ?
public class CommandRequestAttributes extends AbstractRequestAttributes {
// private static final ThreadLocal<CommandRequestAttributes> commandRequestAttributes = new NamedThreadLocal<>("Command RequestAttributes");
/**
* Stores the {@link RequestAttributes#SCOPE_REQUEST} attributes.
* Unlike in {@link CommandSession}, they will be destroyed after command execution completes.
*/
private final Map<String, Object> requestVars = new HashMap<>();
private final CommandSession session;
public CommandRequestAttributes(CommandSession session) {
super();
this.session = session;
}
public CommandSession getSession() {
return session;
}
/**
* Return the RequestAttributes currently bound to the thread.
* <p>Exposes the previously bound RequestAttributes instance, if any.
* @return the RequestAttributes currently bound to the thread
* @throws IllegalStateException if no RequestAttributes object
* is bound to the current thread
* @see RequestContextHolder#currentRequestAttributes()
*/
public static RequestAttributes currentRequestAttributes() throws IllegalStateException {
return ExtCommandSupport.currentRequestAttributes();
}
/* (non-Javadoc)
* @see org.springframework.web.context.request.RequestAttributes#getAttribute(java.lang.String, int)
*/
@Override
public Object getAttribute(String name, int scope) {
switch (scope) {
case SCOPE_REQUEST:
return requestVars.get(name);
case SCOPE_SESSION:
case SCOPE_GLOBAL_SESSION:
return session.get(name);
default:
throw new IllegalArgumentException("Unknown scope: " + scope);
}
}
/* (non-Javadoc)
* @see org.springframework.web.context.request.RequestAttributes#setAttribute(java.lang.String, java.lang.Object, int)
*/
@Override
public void setAttribute(String name, Object value, int scope) {
switch (scope) {
case SCOPE_REQUEST:
requestVars.put(name, value);
break;
case SCOPE_SESSION:
case SCOPE_GLOBAL_SESSION:
session.put(name, value);
break;
}
}
@Override
public void removeAttribute(String name, int scope) {
switch (scope) {
case SCOPE_REQUEST:
requestVars.remove(name);
break;
case SCOPE_SESSION:
case SCOPE_GLOBAL_SESSION:
session.put(name, null);
break;
}
}
@Override
public String[] getAttributeNames(int scope) {
switch (scope) {
case SCOPE_REQUEST:
return requestVars.keySet().toArray(new String[] {});
case SCOPE_SESSION:
case SCOPE_GLOBAL_SESSION:
// see https://issues.apache.org/jira/browse/FELIX-4206
final Collection<String> keySet = (Collection<String>) session.get(null);
return keySet.toArray(new String[] {});
default:
throw new IllegalArgumentException("Unknown scope: " + scope);
}
}
@Override
public void registerDestructionCallback(String name, Runnable callback,
int scope) {
if (scope == SCOPE_REQUEST) {
registerRequestDestructionCallback(name, callback);
} else {
registerSessionDestructionCallback(name, callback);
}
}
/**
* Register the given callback as to be executed after session termination.
* <p>Note: The callback object should be serializable in order to survive
* web app restarts.
* @param name the name of the attribute to register the callback for
* @param callback the callback to be executed for destruction
*/
protected void registerSessionDestructionCallback(String name, Runnable callback) {
// HttpSession session = getSession(true);
// session.setAttribute(DESTRUCTION_CALLBACK_NAME_PREFIX + name,
// new DestructionCallbackBindingListener(callback));
}
@Override
public Object resolveReference(String key) {
if (REFERENCE_REQUEST.equals(key)) {
// return this.request;
return requestVars;
}
else if (REFERENCE_SESSION.equals(key)) {
return session;
}
else {
return null;
}
}
@Override
public String getSessionId() {
return Integer.toHexString(session.hashCode());
}
@Override
public Object getSessionMutex() {
return null;
}
@Override
protected void updateAccessedSessionAttributes() {
}
}
Hendy Irawan opened SPR-10863 and commented
call stack:
It results from the following
@Configuration:PersonRequestConfig is
@Configuration@Lazy@Scope("request") that has no destroy method. So even if Spring tries to call one (which it shouldn't in the first place), the log should be DEBUG.And how did it determine the "destroy()" method name?
Affects: 3.2.4