search

spring-projects / spring-framework

Spring Framework
https://spring.io/projects/spring-framework
Apache License 2.0
56.46k stars 38.09k forks source link

[doc] Update Javadoc on RestTemplate/AsyncRestTemplate to highlight supported HTTP client libraries [SPR-13313] #17898

Closed spring-projects-issues closed 9 years ago

spring-projects-issues commented 9 years ago

Stojan Sljivic opened SPR-13313 and commented

Is there any plan to support non blocking IO, Java NIO2, in AsyncRestTemplate?

Thanks

Referenced from: commits https://github.com/spring-projects/spring-framework/commit/bdf735125f20f652b1a7df0158bd1bac96dacde7

spring-projects-issues commented 9 years ago

Rossen Stoyanchev commented

AsyncRestTemplate can be used with Apache HttpComponents and Netty clients both of which are non-blocking. Can you elaborate?

spring-projects-issues commented 9 years ago

Stojan Sljivic commented

Is there any example how AsyncRestTemplate can be used with Apache HttpComponents and Netty clients?

spring-projects-issues commented 9 years ago

Stojan Sljivic commented

OK, I just realized that there are several implementations of AsyncClientHttpRequestFactory (HttpComponentsAsyncClientHttpRequestFactory, Netty4ClientHttpRequestFactory, etc.).

It would be good to have at least some kind of javadoc in the AsyncRestTemplate that would point out to those implementations and provide some sample configurations. This way users are left to figure out everything from the code it self. I could be wrong, but I could not find any documentation about this.

spring-projects-issues commented 9 years ago

Rossen Stoyanchev commented

Fair enough. The type-level Javadoc should be more explicit about the range of underlying HTTP clients supported. It's an important thing to know up-front.