spring-projects-issues
commented
6 years ago John Butler commented
Juergen, I was the submitter for the DATAMONGO-1964 ticket that triggered this. I was hoping to be able to contribute. If you have not started work on it and I would have time (say a week or set as I need to set up my env for your coding standards) I would like to submit a branch. I was thinking that the simplest change to support immutables (specifically Guava's) would be to add methods in CollectionFactory that take the contents of the Collection / Map
public static <E> Collection<E> createCollectionOf(Class<?> collectionType, Iterable<? extends E> elements) {
...
// Add support for ImmutableCollection, ImmutableList, ImmutableMultiset, ImmutableSet
}
public static <K, V> Map<K, V> createMapOf(Class<?> mapType, Iteable<? extends Map.Entry<? extends K, ? extends V> elements) {...
// Add support for ImmutableMap, ImmutableBiMap
// I don't think code can support ImmutableSortedMap because code would not know what Comparator to use
}
Couple questions, would it make sense for these methods to have a signature that returns the requested type instead of Collection and Map?
Something like:
public static <C extends Collection<E>, E> C createCollectionOf(Class<C> collectionType, Iterable<? extends E> elements)
public static <M extends Map<K,V>, K, V> M createMapOf(ClassM?> mapType, Iteable<? extends Map.Entry<? extends K, ? extends V> elements)
snicoll
Mark Paluch opened SPR-16797 and commented
Modelling application classes as immutable objects is a widely used pattern in Java and Kotlin which constantly gains adoption. We should allow creation of immutable collection types (
Map,List,Set) throughCollectionFactoryor an adequate API that allows specification of the target type and the elements the result should contain.It would be great to support:
Issue Links:
2 votes, 7 watchers