search

spring-projects / spring-framework

Spring Framework
https://spring.io/projects/spring-framework
Apache License 2.0
56.37k stars 38.04k forks source link

Instrument RSocket Requester for Observability #32372

Open riko-traveloka opened 3 years ago

riko-traveloka commented 3 years ago

Hi team, until Spring Boot 2.4.0, there's no metrics auto-configuration for RSocketRequester. Would be nice if there's metrics auto-configuration so that we have visibility over the interaction (request-response, fire-forget, etc), both count and latency.

mbhave commented 3 years ago

I think this is a duplicate of spring-projects/spring-boot#16282.

wilkinsona commented 3 years ago

I'm not sure this is a duplicate. AIUI, spring-projects/spring-boot#16282 is about making the Actuator's endpoints available over RSocket and this issue is about RSocket-related metrics.

riko-traveloka commented 3 years ago

Hi @mbhave, what @wilkinsona said is right. This issue is about enabling RSocketRequester metric and auto-configuration, and not about making actuator available over RSocket.

Currently RSocketRequester doesn't send any metrics (count and latency) CMIIW, and also there's no clean way to add metrics (no customizer).

Maybe just ignore the "actuator" part of this issue to remove confusion.

mbhave commented 3 years ago

Thanks for the clarification @riko-traveloka. I have reopened the issue.

zggg commented 7 months ago

any progress？

bclozel commented 7 months ago

@zggg no progress so far as the demand is quite low. We will need to instrument the RSocket Requester directly in Spring Framework first before considering any auto-configuration in Spring Boot (this is why the issue has been transferred).