search

spring-projects / spring-framework

Spring Framework
https://spring.io/projects/spring-framework
Apache License 2.0
56.77k stars 38.16k forks source link

Add micrometer instrumentation for transactions to spring-tx #33751

Closed edudar closed 1 month ago

edudar commented 1 month ago

With the migration from Spring Cloud Sleuth to Micrometer Tracing, the direction was to move instrumentation support to respective projects. Looking through the code, it doesn't look like support for transactions has been migrated to spring-tx.

The original tx support in Sleuth: https://github.com/spring-cloud/spring-cloud-sleuth/tree/3.1.x/spring-cloud-sleuth-instrumentation/src/main/java/org/springframework/cloud/sleuth/instrument/tx that supports imperative and reactive transaction managers.

bclozel commented 1 month ago

This was considered and declined in https://github.com/spring-projects/spring-framework/pull/28156#issuecomment-1882648708