search

spring-projects / spring-framework

Spring Framework
https://spring.io/projects/spring-framework
Apache License 2.0
56.72k stars 38.15k forks source link

Simplify implementation of `FilteredIterator` #33902

Closed KNU-K closed 5 days ago

KNU-K commented 5 days ago

In my opinion, there are unnecessary 'else' phrases and if phrases.

This can be good in terms of readability, but deepening depth can actually be out of sight.

That's why I modified the same format to be used a little more concisely.

pivotal-cla commented 5 days ago

@KNU-K Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 5 days ago

@KNU-K Thank you for signing the Contributor License Agreement!

KNU-K commented 5 days ago

@sbrannen i have one question. Is my pr contributed?

sbrannen commented 5 days ago

Hi @KNU-K,

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into 6.2.x and main in e0e96c487f2da1c4254413e31012bae486d4da24 and revised in 6544698078873867df5958f9cd1d8a569df10611.

Thanks

sbrannen commented 5 days ago

i have one question. Is my pr contributed?

Yes, it has.

Please note, however, that there is no need to ask that. You can see that yourself by looking at the "events" in the issue, for example: https://github.com/spring-projects/spring-framework/pull/33902#event-15324385628.