Refactor ConcurrentLruCache

spring-projects / spring-framework

Spring Framework

https://spring.io/projects/spring-framework

Apache License 2.0

56.72k stars 38.15k forks source link

Closed rlaehd62 closed 4 days ago

rlaehd62 commented 5 days ago

Forgot to include this change, my previous PR was declined but I create new one for it. Sorry for inconvenience, I'm not used to contribution.

Enhance by adding early return, so that It doesn't run remaining codes.
- I think it's better to place non-null case first in terms of readability 'cause It's still convenience to follow the flow even when new error-catches added.

bclozel commented 4 days ago

I don't think that accepting cosmetic changes on performance-sensitive code is a good tradeoff for the project. Closing this issue.