Currently, our GraphQlObservationInstrumentation wraps the local GraphQLContext when passing it on to the next child DataFetcher in order to set the current observation in the context with the ObservationThreadLocalAccessor.KEY key.
While graphql.GraphQLContext is a popular choice of context implementation, DataFetcher can choose to use custom types that do not extend this type.
We should relax this requirement and make sure to contribute only if the local context in DataFetchingEnvironment is null or if it is already an instance of GraphQLContext.
Currently, our
GraphQlObservationInstrumentationwraps the localGraphQLContextwhen passing it on to the next childDataFetcherin order to set the current observation in the context with theObservationThreadLocalAccessor.KEYkey.While
graphql.GraphQLContextis a popular choice of context implementation,DataFetchercan choose to use custom types that do not extend this type.We should relax this requirement and make sure to contribute only if the local context in
DataFetchingEnvironmentisnullor if it is already an instance ofGraphQLContext.