search

spring-projects / spring-integration-extensions

The Spring Integration Extensions project provides extension components for Spring Integration
http://www.springintegration.org/
279 stars 265 forks source link

Intext 118: Fix message part splitting for long messages containing newlines #130

Closed joensson closed 9 years ago

joensson commented 9 years ago

This pull request concerns INTEXT-118 in spring-integration-smpp.

Long messages that contain newlines were not split into parts of correct size.

The test in the pull request demonstrates that no matter if the message contains newlines or not the splitting results in correctly sized message parts.

I have signed the Individual Contributor Agreement - 98220141112114528

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

artembilan commented 9 years ago

Good. But I didn't hear about the CLA confirmation :smile:

joensson commented 9 years ago

I was so close :) - I have updated the pull request comment - need I do more?

Artem Bilan wrote:

Good. But I didn't hear about the CLA confirmation :smile:

— Reply to this email directly or view it on GitHub https://github.com/spring-projects/spring-integration-extensions/pull/130#issuecomment-62710337.

artembilan commented 9 years ago

I'll take a look to the code closer locally and if there will haven't been critical issues, I'll fix those on merge.

artembilan commented 9 years ago

Please, reformat your code to the 120 line size. Even that SINGLELINE_PAYLOAD can be splitted for several lines without \n :smile:

artembilan commented 9 years ago

Merged as https://github.com/spring-projects/spring-integration-extensions/commit/85334c7e90028db28511e4cf7ce5ba1bee398b32

Thank you very much for the contribution. Looking for for more!

For the future: please add some comment to the PR after pushing commit. Otherwise we don't receive notification about PR changes.