Intext 219 only bug fix

spring-projects / spring-integration-extensions

The Spring Integration Extensions project provides extension components for Spring Integration

http://www.springintegration.org/

279 stars 265 forks source link

Intext 219 only bug fix #161

Closed akryvtsun closed 8 years ago

akryvtsun commented 8 years ago

add unit test
fix bug

artembilan commented 8 years ago

Thank you, @englishman, for the understanding and so fast fix!

artembilan commented 8 years ago

That's all.

I can address them on merge, but would like to hear from you back first of all.

Thank you!

akryvtsun commented 8 years ago

@artembilan i'm done

artembilan commented 8 years ago

Merged as https://github.com/spring-projects/spring-integration-extensions/commit/8dcca5b676f19dc0e070fd4f986311c70aa11a77.

Thank you for contribution.

Looking forward for more!

akryvtsun commented 8 years ago

@artembilan interesting... my PR status after your applying is Closed with unmerged commits Why you haven't simply merge PR? It's just curiosity :)

artembilan commented 8 years ago

We apply only single commit into the master per PR to supply the linear commit history.

So, I rebased and squashed your PR to the single commit.

Also I made some simple code style polishing, like redundant final for local vars, blank lines in some places etc. :-)

Please, read carefully https://github.com/spring-projects/spring-integration/blob/master/CONTRIBUTING.adoc. We have there almost everything about that.