Closed lewisheadden closed 5 years ago
@artembilan thanks for your comments - they were very helpful in guiding me what things to update and what to drop.
I think I managed to work through most of them. I upgraded Gradle Wrapper and fixed all the warnings there too (the spring-integration-kafka
files were very useful to reference).
Although I see that I've squashed it so hard that only Dave's name left in the commit history. I bring my apologies for such a negligence. I will ensure your next commit will be definitely with your name!
Thank you for contribution. Looking forward for more!
The artifact for testing is here: https://repo.spring.io/libs-snapshot-local/org/springframework/integration/spring-integration-etcd/1.0.0-BUILD-SNAPSHOT/
Takes https://github.com/spring-projects/spring-integration-extensions/pull/163 and updates the etcd client to be
com.ibm.etcd:etcd-java
which supports the etcd v3 API.I think there are a few optimizations that could be made with Persistent Leases and other things in etcd v3 but I figured getting it working was a first step.
I also know that @dsyer's PR is fairly old so I may need to update deps but I'm not entirely sure what I need to update!