search

spring-projects / spring-integration-extensions

The Spring Integration Extensions project provides extension components for Spring Integration
http://www.springintegration.org/
279 stars 265 forks source link

Updated jCIFS library to the latest version to support SMB2/SMB3 #207

Closed GregBragg closed 5 years ago

GregBragg commented 5 years ago

Fixes https://github.com/spring-projects/spring-integration-extensions/issues/206

Updated dependent jCIFS library to support SMB2 and SMB3 protocols since SMB1 is no longer supported by the latest versions of Windows servers as it was deemed a security risk by Microsoft. SMB1 has been deprecated.

GregBragg commented 5 years ago

I've updated the readme with some verbiage from https://spring.io/blog/2017/01/18/spring-integration-extension-for-smb-0-5-0-is-available so I hope you don't mind. It helped me out when I first started using this extension. Thanks!

GregBragg commented 5 years ago

Yes I saw that too and I was looking into it... It seems the authors of JCIF deprecated a whole class NtlmPasswordAuthentication, without any reason or suggestions of what else to use. I'll see what I can do.

GregBragg commented 5 years ago

Question: Why do we have this constructor in the code when the only class that is using it is SmbSessionTests? I think we can also deprecate it safely and I'll rewrite the other constructor to authenticate without using the other deprecated class in jCIFS.

public SmbShare(String url) throws IOException {
    super(StringUtils.cleanPath(url));
}
artembilan commented 5 years ago

Right, if underlying library doesn't provide such a feature any more, let's deprecate it from our side as well!

Thanks for digging all the out!

GregBragg commented 5 years ago

Ok well do you want me to change the test class also? Or can it be ignored?

artembilan commented 5 years ago

Please, fix it. No reason to remove anything yet.

Thanks

GregBragg commented 5 years ago

The deprecated constructor issue in jCIFS has been addressed. I tested the snapshot build that I created in my own batch integration that this PR is now depending on with full debugging turned on and it is working perfectly for an SMB2 connection to a file server share.

GregBragg commented 5 years ago

Thanks! Much appreciated...

artembilan commented 5 years ago

Merged as https://github.com/spring-projects/spring-integration-extensions/commit/376a34c03128c013ae063a0b1a3eae51fa3e176d after some minor polishing and upgrades.

@GregBragg ,

Thank you very much for the contribution; looking forward for more!

GregBragg commented 5 years ago

Your very welcome! When can I expect the new 1.1.0.RELEASE build created and pushed to the Maven Repo?

artembilan commented 5 years ago

Let's hope today!

We have some stuff to do in other project and release that as well, then we can come back to this one.

If not today, then definitely on Friday, since we have more to release tomorrow.

Thanks for understanding!