spring-projects / spring-integration-extensions

The Spring Integration Extensions project provides extension components for Spring Integration
http://www.springintegration.org/
280 stars 266 forks source link

spring-integration-zip: Status? #245

Closed mpern closed 3 years ago

mpern commented 3 years ago

Hi all!

What's the status of spring-integration-zip?

If I look at the build, it is still compiled against Spring Integration 4.3 which means it is not really compatible against Spring Integration 5.x

Is there a different/better way to handle zip files?

artembilan commented 3 years ago

Thank you for raising this concern!

If it is not compatible, then we just need to start a new version, fix and release. Our point was to keep only one version for all the backward compatibility to minimize support burden for these extension modules.

How does it look from an exception perspective, please, which would make us to bump Spring Integration Core dependency and start a new version for this Zip project?

mpern commented 3 years ago

The one problematic bit I know of:

There are is a method signature incompatibility in:

org.springframework.integration.zip.transformer.AbstractZipTransformer#doTransform (spring-integration-zip)

protected Object doTransform(Message<?> message) throws Exception 

vs

org.springframework.integration.transformer.AbstractTransformer#doTransform (spring-integration-core 5.x)

protected abstract Object doTransform(Message<?> message)

if you have a custom transformer that extends AbstractZipTransformer it simply doesn't compile

artembilan commented 3 years ago

Yeah... I see your point.

So, from here we are starting a new version 2.0.0 for this Spring Integration Zip extension and making it based on the latest Spring Integration 5.5.

We release it probably tomorrow.

Thank you for your patience!

artembilan commented 3 years ago

The version 2.0.0 for Spring Integration Zip extension has been released: https://github.com/spring-projects/spring-integration-extensions/commit/9f909c62b296e1139414039832a4b933bcd76c34.

Give it a couple hours to appear in Maven Central. Although you can use it already from the: https://repo.spring.io/artifactory/release - https://repo.spring.io/artifactory/release/org/springframework/integration/spring-integration-zip/2.0.0/