search

spring-projects / spring-integration-extensions

The Spring Integration Extensions project provides extension components for Spring Integration
http://www.springintegration.org/
280 stars 266 forks source link

Issue #246 deprecate file replace option, retain minor version #258

Closed GregBragg closed 2 years ago

GregBragg commented 2 years ago

@artembilan as discussed in PR #257:

"For the current one I suggest the plan like this:

  1. Bring back your SmbMessageHandler, but set replaceFile on the provided SmbSessionFactory, not SmbRemoteFileTemplate.
  2. Deprecate those options on the SmbSessionFactory to discourage end-users to use them explicitly.
  3. Leave the logic as is in the SmbSession as is.

This way we should nail both birds: have options deprecated and retain the old behavior in both write() and rename()."

GregBragg commented 2 years ago

I think your changes are very close to what I would expect as a fix for the issue.

I'll pull it locally today for final review and probably will merge after.

Thank you!

Feel free to look into moving this project as a module to the https://github.com/spring-projects/spring-integration with respective overhaul afterwards for a new major version over there.

Awesome! Let me know when you can do a release build as I am waiting on these changes for my services to use. I'd be interested in moving this to the main SI project folder and maintaining it there going forward.

Thanks!

artembilan commented 2 years ago

Merged as https://github.com/spring-projects/spring-integration-extensions/commit/9ef8e04eade8bfeebcaed3b8d60d90fc4ba260dc after some minor clean ups.

I'm going to release that version today.

Thank you for contribution, @GregBragg ; looking forward for more!