spring-projects / spring-integration-samples

You are looking for examples, code snippets, sample applications for Spring Integration? This is the place.
http://www.springsource.org/spring-integration
2.32k stars 2.55k forks source link

Bump sshd-sftp from 2.9.2 to 2.10.0 in /basic/sftp #353

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps sshd-sftp from 2.9.2 to 2.10.0.

Changelog

Sourced from sshd-sftp's changelog.

Version 2.9.1 to 2.9.2

Version 2.9.2 to 2.10.0

Planned for next version

Bug Fixes

  • GH-370 Also compare file keys in ModifiableFileWatcher.

  • GH-371 Fix channel pool in SftpFileSystem.

  • GH-383 Use correct default OpenOptions in SftpFileSystemProvider.newFileChannel().

  • GH-384 Use correct lock modes for SFTP FileChannel.lock().

  • GH-388 ScpClient: support issuing commands to a server that uses a non-UTF-8 locale.

  • SSHD-1259 Consider all applicable host keys from the known_hosts files.

  • SSHD-1310 SftpFileSystem: do not close user session.

  • SSHD-1327 ChannelAsyncOutputStream: remove write future when done.

  • SSHD-1332 (Regression in 2.10.0) Resolve ~ in IdentityFile file names in HostConfigEntry.

New Features

Major Code Re-factoring

As part of the fix for GH-371 the channel pool in SftpFileSystem was rewritten completely. Previous code also used ThreadLocals to store SftpClients, which could cause memory leaks.

These ThreadLocals have been removed, and the channel pool has been rewritten to function similar to a Java ThreadPool: the pool has a maximum size; it has an expiration duration after which an idle channel is removed and closed, and it has a "core size" of channels to keep even if they are idle. If a channel is closed for any reason it is evicted from the pool.

Properties to configure these pool parameters have been added to SftpModuleProperties.

Commits
  • b8429ca [maven-release-plugin] prepare release sshd-2.10.0
  • 2406cbe Prepare 2.10.0 release
  • a61e930 [SSHD-1234] Rooted file system can leak informations
  • f9970ab Remove unwanted reverse lookup
  • d4b951a GH-364: Use flags for RSA signature requests in AbstractAgentClient
  • 9f5c03a Bump spring-core from 5.3.26 to 5.3.27
  • f06217f [releng] OSGi: Ensure the BC security provider can be found
  • 5c80258 Add a test for GH-351
  • c11bfcc GH-281: Follow first-match semantics specified for ssh config file
  • f887414 OpenSSH key parsing: minor clean-ups in new AEAD code paths
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/spring-projects/spring-integration-samples/network/alerts).
artembilan commented 1 year ago

We cannot upgrade to this version since it has a bug properly resolving the path (on non-Windows file systems) for a remote directory to create:

2023-07-11 14:26:23,979 TRACE [sshd-SftpSubsystem-36168-thread-1] [org.apache.sshd.common.file.root.RootedFileSystem] - getPath(/foo/., []): /foo/.
2023-07-11 14:26:23,979 TRACE [sshd-SftpSubsystem-36168-thread-1] [org.apache.sshd.sftp.server.SftpSubsystem] - resolveFile(ServerSessionImpl[foo@/127.0.0.1:44840]) /foo/ => /foo/.
2023-07-11 14:26:23,979 DEBUG [sshd-SftpSubsystem-36168-thread-1] [org.apache.sshd.sftp.server.SftpSubsystem] - doMakeDirectory(ServerSessionImpl[foo@/127.0.0.1:44840])[id=106] SSH_FXP_MKDIR (path=/foo/[/foo/.], attrs={})
2023-07-11 14:26:23,979 TRACE [sshd-SftpSubsystem-36168-thread-1] [org.apache.sshd.common.file.root.RootedFileSystemProvider] - readAttributes(/foo/.)[/tmp/junit1261919202368611685/source/foo/.] type=BasicFileAttributes
2023-07-11 14:26:23,980 DEBUG [sshd-SftpSubsystem-36168-thread-1] [org.apache.sshd.sftp.server.SftpSubsystem] - doSendStatus[ServerSessionImpl[foo@/127.0.0.1:44840]][id=106,cmd=14] exception
java.nio.file.NoSuchFileException: /foo
    at org.apache.sshd.common.file.root.RootedFileSystemProvider.translateIoException(RootedFileSystemProvider.java:585) ~[sshd-common-2.10.0.jar:2.10.0]
    at org.apache.sshd.common.file.root.RootedFileSystemProvider.createDirectory(RootedFileSystemProvider.java:249) ~[sshd-common-2.10.0.jar:2.10.0]
    at java.nio.file.Files.createDirectory(Files.java:700) ~[?:?]
    at org.apache.sshd.sftp.server.SftpFileSystemAccessor.createDirectory(SftpFileSystemAccessor.java:487) ~[sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.AbstractSftpSubsystemHelper.doMakeDirectory(AbstractSftpSubsystemHelper.java:1681) [sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.AbstractSftpSubsystemHelper.doMakeDirectory(AbstractSftpSubsystemHelper.java:1632) [sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.AbstractSftpSubsystemHelper.doProcess(AbstractSftpSubsystemHelper.java:386) [sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.SftpSubsystem.doProcess(SftpSubsystem.java:327) [sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.AbstractSftpSubsystemHelper.process(AbstractSftpSubsystemHelper.java:344) [sshd-sftp-2.10.0.jar:2.10.0]
    at org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:303) [sshd-sftp-2.10.0.jar:2.10.0]
dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.