search

spring-projects / spring-modulith

Modular applications with Spring Boot
https://spring.io/projects/spring-modulith
Apache License 2.0
784 stars 131 forks source link

Expose stream/List of Events for incompleteEventPublications #581

Open zikozee opened 5 months ago

zikozee commented 5 months ago

I am looking at a scenario where I can dynamically batch the incomplete events which can also give room to do some extra work before or after.

patrzalektom commented 4 months ago

@odrotbohm - the thing mentioned here is that CompletedEventPublications interface exposes a method findAll() which would return all completed event publications, but IncompleteEventPublications does not provide such a method and there's a need to inject EventPublicationRegistry (e.g. in tests) to assert anything related to incomplete publications.

This difference might be misleading in my opinion.

I could try handling this and opening a pull request with that, what do you think about that?

patrzalektom commented 4 months ago

Mentioned pull request: https://github.com/spring-projects/spring-modulith/pull/616