search

spring-projects / spring-modulith

Modular applications with Spring Boot
https://spring.io/projects/spring-modulith
Apache License 2.0
813 stars 140 forks source link

Rename `FormatableType` to `FormattableType` #813

Closed breun closed 1 month ago

breun commented 2 months ago

I'm not a native English speaker, but I believe that if something can be formatted, then it is 'formattable' rather than 'formatable', so I believe the class name FormatableType should be renamed to FormattableType.

odrotbohm commented 2 months ago

Good catch! Unfortunately, I think this will have to wait until 2.0 as it's a public type and fixing the typo will break existing clients.

breun commented 2 months ago

Maybe FormattableType can already be introduced before 2.0 next to Formatabletype by letting FormattableType extend FormatableType and marking FormatableType as deprecated for removal in 2.0?

Then Spring Modulith itself could already switch to FormattableType and existing users can also already switch before 2.0 if they want.