search

spring-projects / spring-petclinic

A sample Spring-based application
Apache License 2.0
7.68k stars 23.74k forks source link

Distributed PetClinic with Spring Cloud #198

Closed mszarlinski closed 7 years ago

mszarlinski commented 7 years ago

I would like to provide a "Spring Cloud" branch for the application to show how to split existing monolithic application into microservices. Distributed vesion would be based on a codebase from "angularjs" branch . What do you guys think?

arey commented 7 years ago

I Maciej. This could be a great idea but could you please wait one or two weeks? Indeed the angularjs branch will be move to another repository.

mszarlinski commented 7 years ago

Thanks for your replay. Actually I'm almost finished with a basic version built with Spring Cloud Config, Eureka, Hystrix and Zuul. Of course I can wait with a pull request for the new repository. By the time it is created, I should be ready with adjusted Docker setup. You can assign a task to me.

dsyer commented 7 years ago

You might want to look at #200 as well. That kind of modularization could be useful. if you are going to split the "monolith" (otherwise I can't see the point of introducing all the Spring Cloud stack).

mszarlinski commented 7 years ago

Hi Dave, thanks for your comment. I already did something similar with Visit entity when I was trying to define bounded contexts. And yes, I'm going to split the monolith :)

arey commented 7 years ago

Dave, you may see the Maciej's work here: https://github.com/spring-petclinic/spring-petclinic-microservices Now that the Spring Cloud Petclinic has its own repo, we could close this question.

mszarlinski commented 7 years ago

@dsyer any comments and suggestions are certainly welcome :) I think after some time I will refresh microservices branch from this master (for example get rid of a thin service layer).