search

spring-projects / spring-plugin

Apache License 2.0
441 stars 117 forks source link

Changed J2SE-1.6 to JavaSE-1.6 #26

Closed shanmukhm closed 8 years ago

shanmukhm commented 8 years ago

As there's no environment called J2SE-1.6 refer: http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.pde.doc.user%2Ftasks%2Fpde_compilation_env.htm

odrotbohm commented 8 years ago

Seems to duplicate #25.

shanmukhm commented 8 years ago

@olivergierke This is not a duplicate. This change is for metadata module and #24 is for 'core' module.

odrotbohm commented 8 years ago

I see. Care to just add that change to the other PR then? I'd rather make it one commit fixing the issue for all modules.

shanmukhm commented 8 years ago

yeah sure. I changed these using github ui. It created two PRs. I will try to make it one commit.

odrotbohm commented 8 years ago

You should able to just push another commit to the branch you created for the other PR. That will accumulate changes then.

shanmukhm commented 8 years ago

Now check it. I made another commit in 'patch-1' branch.