search

spring-projects / spring-plugin

Apache License 2.0
441 stars 117 forks source link

OrderAwarePluginRegistryUnitTest.assertOrder does not compare results with expected inputs #29

Closed mcollovati closed 7 years ago

mcollovati commented 8 years ago

In OrderAwarePluginRegistryUnitTest.assertOrder there is a for loop to assert that results are in correct order but the code compares items from the same list

  for (int i = 0; i < plugins.length; i++) {
    assertThat(result.get(i), is(result.get(i)));
  }

but I think it the assertion should be assertThat(result.get(i), is(plugins[i]));