search

spring-projects / spring-security

Spring Security
http://spring.io/projects/spring-security
Apache License 2.0
8.45k stars 5.76k forks source link

Improved error message for PasswordEncoder #14968

Open bottlerocketjonny opened 3 weeks ago

bottlerocketjonny commented 3 weeks ago

I fear I might have been too slow to submit this! However, this closes gh-14880

Happy to make any changes.

jzheaux commented 3 weeks ago

Hi, @bottlerocketjonny! Yes, we already received another PR for the same and I think it is a nice improvement. That said, if you'd like, please rebase once that is merged and push any other changes you'd like to see to this PR, and we can take a look together.

bottlerocketjonny commented 3 weeks ago

Hi, @bottlerocketjonny! Yes, we already received another PR for the same and I think it is a nice improvement. That said, if you'd like, please rebase once that is merged and push any other changes you'd like to see to this PR, and we can take a look together.

No worries! Yeah sure thing I shall do that 👍🏻

Just for future reference, if I wanted to work on an issue should I wait to be assigned or just go for it? I left a comment on this one but wasn't sure if that was the way to go. Cheers 😀