spring-projects / spring-security

Spring Security
http://spring.io/projects/spring-security
Apache License 2.0
8.55k stars 5.79k forks source link

Mention all required dependencies in LDAP documentation #15235

Closed Harsh4902 closed 1 week ago

Harsh4902 commented 2 weeks ago
pivotal-cla commented 2 weeks ago

@Harsh4902 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 2 weeks ago

@Harsh4902 Thank you for signing the Contributor License Agreement!

sjohnr commented 1 week ago

Thanks @Harsh4902, this is merged as 92cab2b678bac4881b5ad78168f26e5467edb9ce with polish commit f622d8e2e22fbf39800a9c0d083b78c0e75760b7. I adjusted the wording to mention Spring Boot and fixed the build failure with attributes by removing the versions which aren't needed here.

Harsh4902 commented 1 week ago

@sjohnr Thank you for helping, and sorry for the issue of that version attribute.

sjohnr commented 1 week ago

Not a problem @Harsh4902. Thanks for your contribution!