spring-projects / spring-security

Spring Security
http://spring.io/projects/spring-security
Apache License 2.0
8.55k stars 5.79k forks source link

LoginPageGeneratingWebFilter类把网页依赖的地址写死了 #15238

Closed qq664042 closed 1 week ago

qq664042 commented 1 week ago

Describe the bug A clear and concise description of what the bug is. https://github.com/spring-projects/spring-security/blob/main/web/src/main/java/org/springframework/security/web/server/ui/LoginPageGeneratingWebFilter.java 中的createPage方法,把maxcdn.bootstrapcdn.com、getbootstrap.com地址写死在代码里面。

To Reproduce Steps to reproduce the behavior. image image

Expected behavior A clear and concise description of what you expected to happen. maxcdn.bootstrapcdn.com、getbootstrap.com应该是可以动态指定或者使用相对地址。不然的话,使用的电脑访问不到这两个地址就非常麻烦。比如在中国大陆地区访问它会非常慢。

sjohnr commented 1 week ago

Hi @qq664042, thanks for reaching out! Unfortunately I cannot read most of what you wrote, please consider translating it into English before posting.

Having said that, please see this comment, which states:

the generated login and logout pages of Spring Security are intended for getting started only, and should be replaced by a custom login page for production deployments. It is quite easy to do and demonstrated in the samples repository.

You can replace the login page if it is giving you problems. I'm going to close this issue with the above explanation.