search

spring-projects / spring-security

Spring Security
http://spring.io/projects/spring-security
Apache License 2.0
8.79k stars 5.9k forks source link

SEC-1853: Adding custom parameters to CAS redirect login URL #2089

Closed spring-projects-issues closed 12 years ago

spring-projects-issues commented 12 years ago

Andre Albino Pereira (Migrated from SEC-1853) said:

I would like to add custom parameters to the CAS login URL when redirecting user to CAS. These parameters (in my configuration) can be found in the "HttpServletRequest" object which is passed to "org.springframework.security.cas.web.CasAuthenticationEntryPoint.commence(HttpServletRequest, HttpServletResponse, AuthenticationException)". Could "HttpServletRequest" parameter be also passed to "org.springframework.security.cas.web.CasAuthenticationEntryPoint.createRedirectUrl(String)" just like is passed to "org.springframework.security.cas.web.CasAuthenticationEntryPoint.createServiceUrl(HttpServletRequest, HttpServletResponse)"? I couldn't even extend CasAuthenticationEntryPoint since "commence" and pretty much most of the methods in spring-securty CAS component use the "final" modifier.

spring-projects-issues commented 12 years ago

Rob Winch said:

Since there really is very little logic in the CasAuthenticationEntryPoint and this is a fairly low use case I think the right answer for this is to write your own AuthenticationEntryPoint.

spring-projects-issues commented 12 years ago

Andre Albino Pereira said:

If you say so. I agree it's a minor issue, but since the refactoring is trivial, wouldn't hurt to ask. The problem is that I have other extension issues that are located in Java CAS client side (except for this one), which I also asked for refactoring (see https://issues.jasig.org/browse/CASC-167 for example). The final result is 90% of copied code from the default implementation to change the behavior to a specific (but plausible) use case.