spring-projects / spring-session

Spring Session
https://spring.io/projects/spring-session
Apache License 2.0
1.85k stars 1.1k forks source link

Improve caching of `requestedSession` #3063

Open marcusdacoregio opened 1 month ago

marcusdacoregio commented 1 month ago

As of now, the requestedSession is cached as a field in the request wrapper.

The majority of servlet containers recycle their request objects and return them to the pool for reuse. Since the requestedSession is stored in the wrapper level (not as an request attribute like currentSession), it won't be recycled. We should improve this in a way that when the request is recycled, the requestedSession is also "cleared".

Thanks @swendlandt for the help identifying this improvement.