search

spring-projects / spring-shell

Spring based shell
http://projects.spring.io/spring-shell/
Apache License 2.0
710 stars 391 forks source link

gh-277: parse commented line like an empty line #1087

Open polo7 opened 1 month ago

polo7 commented 1 month ago

This PR is intended to fix issue GH-277. Idea: we parse a line and then evaluate despite it is commented. If there is a quote inside of comment then we get an exception "Missing a closing quote" (line 141 in spring-shell-core/src/main/java/org/springframework/shell/jline/ExtendedDefaultParser.java). To avoid this behavoir we should treat commented line like an empty. Then evaluate() from spring-shell-core/src/main/java/org/springframework/shell/Shell.java will take care of it with its "fail fast" on line 195.

polo7 commented 3 weeks ago

Hello, @jvalkeal ! I didn't want to disturb you but it seems you are the only active official in this repo. Could you please guide me with my further steps? I guess I need your approval here.