Quotes Should Not Be Recognized In Comments

spring-projects / spring-shell

Spring based shell

http://projects.spring.io/spring-shell/

Apache License 2.0

723 stars 395 forks source link

Quotes Should Not Be Recognized In Comments #277

Open jlevy-bigfootbiomedical opened 5 years ago

jlevy-bigfootbiomedical commented 5 years ago

Both double and single quotes are recognized (or "active") inside of comments, which I think is a bug. The following two line Spring Shell script will not print help: // don't do this help

And if you put those two lines in a file, and try to run it with the at-sign on the command line, it will crash and you will get this: Caused by: org.jline.reader.EOFError: Missing closing quote

dougbot01 commented 4 years ago

I also have found this to be a problem, especially when running script files as mentioned.

Is there a way to up-vote a fix for this? If someone can point to where this might be broken (spring shell vs jLine) maybe I can dig into a fix.

polo7 commented 3 months ago

Dear colleagues, I've created a PR to fix this issue. Could you please approve merging if there are no objections. @jvalkeal