spring-projects / spring-shell

Spring based shell
http://projects.spring.io/spring-shell/
Apache License 2.0
734 stars 396 forks source link

Declare module descriptor (JPMS, Java 9+, Project Jigsaw) #315

Closed C-Otto closed 2 years ago

C-Otto commented 3 years ago

Using spring-shell in a project which uses JPMS (Project Jigsaw) produces errors like this:

package org.springframework.shell.standard is declared in the unnamed module

Please provide a module name for the library.

$ jar --file=~/.gradle/caches/modules-2/files-2.1/org.springframework.shell/spring-shell-core/2.0.0.RELEASE/75a94aaa62302ee0d5020fca1962b5d63c23a075/spring-shell-core-2.0.0.RELEASE.jar --describe-module
No module descriptor found. Derived automatic module.

spring.shell.core@2.0.0.RELEASE automatic
requires java.base mandated
contains org.springframework.shell
contains org.springframework.shell.jline
contains org.springframework.shell.result
jvalkeal commented 2 years ago

Closing this for limited support #529.

We can revisit if ecosystem gets better. More info i.e. in https://github.com/spring-projects/spring-framework/issues/18079 and https://github.com/spring-projects/spring-boot/issues/13799.