search

spring-projects / spring-shell

Spring based shell
http://projects.spring.io/spring-shell/
Apache License 2.0
734 stars 396 forks source link

Upgrade jline 3.24.1 #901

Closed jvalkeal closed 1 year ago

jvalkeal commented 1 year ago

Just adding a note here as something happens in tests if jna is in classpath. Actual shell samples seem to run fine if compiling without running tests:

> Task :spring-shell-core:compileTestJava
Note: /home/jvalkealahti/repos/spring/spring-shell/main/spring-shell-core/src/test/java/org/springframework/shell/component/support/SelectorListTests.java uses unchecked or unsafe operations.
/home/jvalkealahti/.sdkman/candidates/java/22.3.r17-nik/bin/java: symbol lookup error: /tmp/jlinenative-3.24.1-3bd24c3fe1702ab0-libjlinenative.so: undefined symbol: openpty

> Task :spring-shell-samples:spring-shell-sample-commands:test FAILED

FAILURE: Build failed with an exception.
jvalkeal commented 1 year ago

The error above is related to https://github.com/jline/jline3/issues/896. We can work around it in test system by disabling jni provider. I'm also thinking to disable it on default in terminal auto-config.