search

spring-projects / spring-statemachine

Spring Statemachine is a framework for application developers to use state machine concepts with Spring.
1.54k stars 603 forks source link

Make UmlStateMachineModelFactory support generics State Machines #590

Open don-vip opened 6 years ago

don-vip commented 6 years ago

I am new to Spring StateMachine and very interested in creating a State Machine using UML2 diagram with Eclipse Papyrus.

During my tests with 2.0.2 I was surprised to see UmlStateMachineModelFactory only accepts String events and states and not enums:

public class UmlStateMachineModelFactory extends AbstractStateMachineModelFactory<String, String>
        implements StateMachineModelFactory<String, String>

Is there a specific reason to not accept generics StateMachine in this factory? If it proves to be possible, would you accept a Pull Request changing this behaviour?

don-vip commented 5 years ago

@jvalkeal I would be happy to propose a PR for Hacktoberfest if you agree to this change.