search

spring-projects / spring-vault

Provides familiar Spring abstractions for HashiCorp Vault
https://spring.io/projects/spring-vault
Apache License 2.0
283 stars 186 forks source link

Override for TLS Authentication Path #664

Closed user404d closed 3 years ago

user404d commented 3 years ago

Problem: The path option available for vault authentication methods is not used when configuring the certificate authentication client.

Context: We have a deployment where we mount the certificate authentication method to a path different from the default ("cert") and need our applications to use the path we have chosen.

Relevant links:

https://github.com/spring-cloud/spring-cloud-vault/blob/99f49bec23b63e18b826d6442ae991be1c7456a9/spring-cloud-vault-config/src/main/java/org/springframework/cloud/vault/config/ClientAuthenticationFactory.java#L121

https://github.com/spring-projects/spring-vault/blob/86dbf474bb9f10114148b125ad948266c06442c3/spring-vault-core/src/main/java/org/springframework/vault/authentication/ClientCertificateAuthentication.java#L58-L59

https://github.com/spring-projects/spring-vault/blob/86dbf474bb9f10114148b125ad948266c06442c3/spring-vault-core/src/main/java/org/springframework/vault/authentication/ClientCertificateAuthenticationOptions.java#L74

I am worried about what my employer considers theirs so sorry for being a bit vague. I also don't know how to fix the first link so it does the pretty inline code preview thing /shrug

user404d commented 3 years ago

Oops, wrong project. :)

Reopened here https://github.com/spring-cloud/spring-cloud-vault/issues/610