`ReactiveVaultTemplate` for the key-value backend version 2

spring-projects / spring-vault

Provides familiar Spring abstractions for HashiCorp Vault

https://spring.io/projects/spring-vault

Apache License 2.0

284 stars 186 forks source link

`ReactiveVaultTemplate` for the key-value backend version 2 #807

Closed tweiand closed 1 year ago

tweiand commented 1 year ago

What is done:

Add version 2 (by porting blocking code APIs)
Unit tests for all additional classes
Maybe some code deduplication and cleanup
A second round of editing java docs
Using WebClient to do all object conversion
Created data object to represent the v2 nested data

Questions I have:

Is author attribution correct since this can be considered a port of the block code?
Overall, what do you think about the change?

What I am looking at:

Java docs
Code deduplication and static analysis
Cleaning up the diff

I am available for video chat.

tweiand commented 1 year ago

@mp911de - I had a bad git config when doing most of the work on this. After we finish review, would it be possible for me to re-make the branch so that the commits look correct?

mp911de commented 1 year ago

Sure. A force-push is fine. Am 26. Aug. 2023, 01:10 +0200 schrieb Timothy R. Weiand @.***>:

@mp911de - I had a bad git config when doing most of the work on this. After we finish review, would it be possible for me to re-make the branch so that the commits look correct? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

tweiand commented 1 year ago

Force pushed the branch with the correct email for me. I have 2 questions buried in the comments. Thanks for the help!

mp911de commented 1 year ago

Thank you for your contribution. That's merged and polished now. I took care of all license headers, author and since-tags.