Add support for custom kv2 metadata

spring-projects / spring-vault

Provides familiar Spring abstractions for HashiCorp Vault

https://spring.io/projects/spring-vault

Apache License 2.0

283 stars 186 forks source link

Add support for custom kv2 metadata #808

Closed commjoen closed 1 year ago

commjoen commented 1 year ago

This is a first attempt (in Draft, not yet completed) to add custom_metadata to Metadata

Closes #789

TODO:

[x] Agree on the approach written here
[x] Update integration tests
[x] Add documentation where required

pivotal-cla commented 1 year ago

@commjoen Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 1 year ago

@commjoen Thank you for signing the Contributor License Agreement!

mp911de commented 1 year ago

The changes are pretty straight-forward by adding another property to the already existing types. Once you add tests, we're happy to move forward toward merging this pull request.

commjoen commented 1 year ago

Hi @mp911de , I think the code is ready for a review. Can you please review it?

mp911de commented 1 year ago

Looks good, I'll take your pull request from here.

mp911de commented 1 year ago

Thank you for your contribution. That's merged and polished now.

commjoen commented 1 year ago

Thank you @mp911de !